Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 564063002: Generate simple code for "trivial" conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 564063002: Generate simple code for "trivial" conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index 29d02eebc70c6c33ea9f76321058ae4eca009ece..10943c894ce7f704d0e34800a44c0768e8552271 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -85,10 +85,8 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

V8StringResource<> defaultNullStringOptionalstringArg;

V8StringResource<> optionalStringArg;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

TOSTRING_VOID_INTERNAL(stringArg, info[0]);

- TONATIVE_VOID_INTERNAL(defaultUndefinedOptionalBooleanArg, info[1]->BooleanValue());

+ defaultUndefinedOptionalBooleanArg = info[1]->BooleanValue();

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultUndefinedOptionalLongArg, toInt32(info[2], exceptionState), exceptionState);

TOSTRING_VOID_INTERNAL(defaultUndefinedOptionalStringArg, info[3]);

if (!info[4]->IsUndefined()) {