display error message for empty distilled content

display error message for empty distilled content

also:
- ensure that error message is displayed for empty title
- move dom_distiller_viewer.html/js from content to core dir
- added tests.

BUG=403066
Committed: https://crrev.com/3695ffef35abf39c0ea4b38ea4ccfca7764a109a
Cr-Commit-Position: refs/heads/master@{#296719}

[kuan, 2014-09-11 21:24:14]

kuan@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2014-09-15 07:14:03]

lgtm as is, but it seems possible to add tests for this as well. Is that
something you could take on?

[kuan, 2014-09-18 22:27:02]

i've added test in patch set 2.  ptal.  thx.

[kuan, 2014-09-19 14:23:56]

pls hold off.. i need to add tests for the other method.

[kuan, 2014-09-19 17:11:57]

the tests are now complete in patch set 3.  ptal.  thx.

[nyquist, 2014-09-19 23:47:05]

lgtm

https://codereview.chromium.org/563923002/diff/40001/components/dom_distiller...
File components/dom_distiller/core/viewer_unittest.cc (right):

https://codereview.chromium.org/563923002/diff/40001/components/dom_distiller...
components/dom_distiller/core/viewer_unittest.cc:174: std::string some_title =
"some title";
should these be const?

[kuan, 2014-09-19 23:51:31]

i've addressed your comment in patch set 4, sending to cq now...

https://codereview.chromium.org/563923002/diff/40001/components/dom_distiller...
File components/dom_distiller/core/viewer_unittest.cc (right):

https://codereview.chromium.org/563923002/diff/40001/components/dom_distiller...
components/dom_distiller/core/viewer_unittest.cc:174: std::string some_title =
"some title";
On 2014/09/19 23:47:04, nyquist wrote:
> should these be const?

Done.

[kuan, 2014-09-19 23:51:35]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:52:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563923002/60001

[commit-bot: I haz the power, 2014-09-20 00:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-20 00:14:41]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kuan, 2014-09-22 20:21:17]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:22:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563923002/80001

[commit-bot: I haz the power, 2014-09-22 20:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 20:51:51]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[kuan, 2014-09-23 20:30:15]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-09-23 20:36:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563923002/100001

[commit-bot: I haz the power, 2014-09-23 21:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:50:11]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[kuan, 2014-09-23 22:18:09]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-09-23 22:19:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563923002/120001

[commit-bot: I haz the power, 2014-09-23 23:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 23:37:42]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[kuan, 2014-09-25 00:41:08]

i've modified the cl based on our offline discussion.  all green trybots never
look so good :)  ptal.  thx.

[nyquist, 2014-09-25 04:55:59]

https://codereview.chromium.org/563923002/diff/140001/components/components_t...
File components/components_tests.gyp (right):

https://codereview.chromium.org/563923002/diff/140001/components/components_t...
components/components_tests.gyp:849: # Dependencies of dom_distiller
These now become out of order. Was your thought that this comment is better for
new readers than consistent ordering?

[kuan, 2014-09-25 14:53:06]

https://codereview.chromium.org/563923002/diff/140001/components/components_t...
File components/components_tests.gyp (right):

https://codereview.chromium.org/563923002/diff/140001/components/components_t...
components/components_tests.gyp:849: # Dependencies of dom_distiller
On 2014/09/25 04:55:59, nyquist wrote:
> These now become out of order. Was your thought that this comment is better
for
> new readers than consistent ordering?

yes, like @304.

[nyquist, 2014-09-25 15:32:40]

lgtm

[kuan, 2014-09-25 15:57:26]

The CQ bit was checked by kuan@chromium.org

[commit-bot: I haz the power, 2014-09-25 15:57:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/563923002/140001

[commit-bot: I haz the power, 2014-09-25 16:23:25]

Committed patchset #8 (id:140001) as 24db7bff758983bc10475812c30c3110e4cc1cab

[commit-bot: I haz the power, 2014-09-25 16:24:00]

Patchset 8 (id:??) landed as
https://crrev.com/3695ffef35abf39c0ea4b38ea4ccfca7764a109a
Cr-Commit-Position: refs/heads/master@{#296719}