Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: components/components_tests.gyp

Issue 563923002: display error message for empty distilled content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move test to browsertest to bypass missing resources on ios/android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/dom_distiller/content/distiller_page_web_contents_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components_tests.gyp
diff --git a/components/components_tests.gyp b/components/components_tests.gyp
index 162c7a19e4e7736a2ce8921bbf22cd0c98cfaa56..bb9f03ef52adc0f96549cb42689780131e7132f9 100644
--- a/components/components_tests.gyp
+++ b/components/components_tests.gyp
@@ -831,8 +831,6 @@
'defines!': ['CONTENT_IMPLEMENTATION'],
'dependencies': [
'components.gyp:autofill_content_browser',
- 'components.gyp:dom_distiller_content',
- 'components.gyp:dom_distiller_core',
'components.gyp:password_manager_content_renderer',
'components.gyp:pref_registry_test_support',
'components_resources.gyp:components_resources',
@@ -847,6 +845,11 @@
'../skia/skia.gyp:skia',
'../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
+
+ # Dependencies of dom_distiller
nyquist 2014/09/25 04:55:59 These now become out of order. Was your thought th
kuan 2014/09/25 14:53:06 yes, like @304.
+ 'components.gyp:dom_distiller_content',
+ 'components.gyp:dom_distiller_core',
+ 'components_strings.gyp:components_strings',
],
'include_dirs': [
'..',
« no previous file with comments | « no previous file | components/dom_distiller/content/distiller_page_web_contents_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698