Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 563793002: Use conversion helpers in V8Binding.cpp for [Clamp] method arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index 8541c9bd2210c5a75bc94404a26a66e7d52bd322..7a3d270d0d1dddaadce88f5db483a53b532c580b 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -54,7 +54,6 @@ CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES = frozenset([
def argument_needs_try_catch(method, argument):
return_promise = method.idl_type and method.idl_type.name == 'Promise'
- is_clamp = 'Clamp' in argument.extended_attributes
idl_type = argument.idl_type
base_type = idl_type.base_type
@@ -74,8 +73,7 @@ def argument_needs_try_catch(method, argument):
# exceptions via it, and doesn't need/use a TryCatch, except if the
# argument has [Clamp], in which case it uses a separate code path in
# Source/bindings/templates/methods.cpp, which *does* use a TryCatch.
- (idl_type.v8_conversion_needs_exception_state and
- not is_clamp))
+ idl_type.v8_conversion_needs_exception_state)
def use_local_result(method):
@@ -254,7 +252,6 @@ def argument_context(interface, method, argument, index):
'idl_type': idl_type.base_type,
'idl_type_object': idl_type,
'index': index,
- 'is_clamp': 'Clamp' in extended_attributes,
'is_callback_interface': idl_type.is_callback_interface,
'is_nullable': idl_type.is_nullable,
'is_optional': argument.is_optional,
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698