Source/bindings/scripts/v8_types.py - Issue 563793002: Use conversion helpers in V8Binding.cpp for [Clamp] method arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 563793002: Use conversion helpers in V8Binding.cpp for [Clamp] method arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 746bf9c15d680356c88b8995b056cb81fce76e99..c5941bcecb5a0b8e9ba223b613e6a8a37ed92203 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -497,6 +497,8 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index, isolat

if 'EnforceRange' in extended_attributes:

arguments = ', '.join([v8_value, 'EnforceRange', 'exceptionState'])

+ elif 'Clamp' in extended_attributes:

+ arguments = ', '.join([v8_value, 'Clamp', 'exceptionState'])

elif idl_type.v8_conversion_needs_exception_state:

arguments = ', '.join([v8_value, 'exceptionState'])

else:

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »