Use conversion helpers in V8Binding.cpp for [Clamp] method arguments

Use conversion helpers in V8Binding.cpp for [Clamp] method arguments

There was custom generated code specifically for handling arguments with
[Clamp], which is quite unnecessary since the toUInt*() have an integer
conversion configuration parameter that among other things can be used to
request clamping.

Related: Fix the somewhat broken handling the |Clamp| integer conversion
configuration in the toUInt*() helpers. An optimization code path for the
case that the V8 value is an int32 forgot to do clamping, there was no
clamping at all in toUInt64(), and +/- Infinity was converted to zero
instead of being clamped.

Clamping support is not added to toInt64(), since the clampTo<> helper in
Source/wtf/MathExtras.h explicitly doesn't support |long long int|, which
is int64_t on some platforms.

BUG=413257
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181882

[Jens Widell, 2014-09-11 14:34:29]

jl@opera.com changed reviewers:
+ haraken@chromium.org, sigbjornf@opera.com

[Jens Widell, 2014-09-11 14:34:30]

PTAL

I thought this would be a trivial clean-up, then ended up making more changes
than intended in V8Binding.cpp. For the better, I think; and that special case
for [Clamp] arguments was getting in the way of things.

[haraken, 2014-09-11 15:01:37]

LGTM

If it will take a bunch of more patches to remove v8::TryCatch from the
auto-generated code, you might want to create a tracking bug so that others can
follow our work.

[Jens Widell, 2014-09-11 15:06:45]

On 2014/09/11 15:01:37, haraken wrote:
> If it will take a bunch of more patches to remove v8::TryCatch from the
> auto-generated code, you might want to create a tracking bug so that others
can
> follow our work.

It'll be a few more, so yes, I should do that.

[Jens Widell, 2014-09-11 15:16:51]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-11 15:17:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563793002/1

[commit-bot: I haz the power, 2014-09-11 15:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 15:29:20]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54678)

[Jens Widell, 2014-09-12 05:45:39]

On 2014/09/11 15:29:20, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_gpu on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54678)

MathExtras.h has a special case for |long long int| which makes it not
supported. On some platforms (notably not 64-bit Linux, which I'm on) that means
clampTo<int64_t>() is not supported, and thus that toInt64() can't do clamping.

We don't need that functionality now anyway, so I removed the clamping code I
added in toInt64() again, and replaced it with an assert checking that it's not
called with configuration==Clamp.

[haraken, 2014-09-12 06:30:45]

Still LGTM

[Jens Widell, 2014-09-12 06:49:47]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-12 06:49:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563793002/20001

[commit-bot: I haz the power, 2014-09-12 06:56:25]

Committed patchset #2 (id:20001) as 181882