Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Issue 563713002: Revert of Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
joleksy
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. (patchset #2 id:20001 of https://codereview.chromium.org/302593002/) Reason for revert: Aura builds fail DCHECKs: ASSERTION FAILED: event.type() == PlatformEvent::MouseMoved || event.button() != NoButton third_party/WebKit/Source/core/events/MouseEvent.cpp(54) blink::MouseEvent::create() blink::Node::dispatchMouseEvent() blink::EventHandler::dispatchMouseEvent() blink::EventHandler::handleMousePressEvent() blink::PageWidgetEventHandler::handleMouseDown() blink::WebViewImpl::handleMouseDown() blink::WebViewImpl::handleMouseDown() blink::PageWidgetDelegate::handleInputEvent() blink::WebViewImpl::handleInputEvent() content::RenderWidget::OnHandleInputEvent() Original issue's description: > Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent. > > Event::flags() contains all the buttons that are being held down during the event, while MouseEvent::changed_button_flags() contains the buttons that are actually pressed/released during the event (and this is what we really are interested in). > > This fixes the issue with LMB being pressed while RMB is being held down. Without the fix, we always get blink::WebMouseEvent::ButtonRight in blink::WebMouseEvent::button. > > Committed: https://crrev.com/87e6b0f6d72b12e4b0308b035d1c06f2beb90feb > Cr-Commit-Position: refs/heads/master@{#293487} TBR=joleksy@opera.com NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2591b1df63b910457706206b13d998f1e3069e89 Cr-Commit-Position: refs/heads/master@{#294364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Use changed_button_flags() when converting MouseEvent to blink::WebMouseEvent.
6 years, 3 months ago (2014-09-11 09:33:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563713002/1
6 years, 3 months ago (2014-09-11 09:34:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 38c9e1a43d77914c3309a6c7b37d79e6eeaa3496
6 years, 3 months ago (2014-09-11 09:35:16 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 09:39:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2591b1df63b910457706206b13d998f1e3069e89
Cr-Commit-Position: refs/heads/master@{#294364}

Powered by Google App Engine
This is Rietveld 408576698