Clean up extensions permissions unit tests

Clean up extensions permissions unit tests

* Move socket_permission_unittest.cc and usb_device_permission_unittest.cc
  into src/extensions -- they have no src/chrome dependencies.
* Move permissions_data_unittest.cc back into src/chrome -- its tests rely on
  extension manifest keys that aren't part of src/extensions yet.
* Rename the latter tests to PermissionsDataTest

BUG=397165
TEST=unit_tests PermissionsDataTest.* and extensions_unittests

Committed: https://crrev.com/646de7d89ca220cdd533bcd35f55768c1ad5dda1
Cr-Commit-Position: refs/heads/master@{#294493}

[James Cook, 2014-09-11 00:21:27]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2014-09-11 00:21:28]

rockot, PTAL.

I spent the afternoon trying to come up with a clean way to keep
permissions_data_unittest.cc in src/extensions but the solutions are all ugly.

Most of the tests rely on test data with manifest keys supported only by chrome.
Moving the manifest keys quickly hits a dependency on chrome version/channels. A
couple tests don't use those keys, but moving them out requires a copy/paste
version of extension_test_utils::LoadManifest (and friends) to read the test
data out of extensions/test/data.

Basically, I think the cure is worse than the disease and these tests should
stay in chrome for now.  On the plus side I found a couple other tests to move
out. :-)

[Ken Rockot(use gerrit already), 2014-09-11 16:02:07]

On 2014/09/11 00:21:28, James Cook wrote:
> rockot, PTAL.
> 
> I spent the afternoon trying to come up with a clean way to keep
> permissions_data_unittest.cc in src/extensions but the solutions are all ugly.
> 
> Most of the tests rely on test data with manifest keys supported only by
chrome.
> Moving the manifest keys quickly hits a dependency on chrome version/channels.
A
> couple tests don't use those keys, but moving them out requires a copy/paste
> version of extension_test_utils::LoadManifest (and friends) to read the test
> data out of extensions/test/data.
> 
> Basically, I think the cure is worse than the disease and these tests should
> stay in chrome for now.  On the plus side I found a couple other tests to move
> out. :-)

LGTM and I agree about things staying in Chrome. It would be nice if we could
eventually get some tests in //extensions that dealt with non-Chrome-specific
behavior though.

[James Cook, 2014-09-11 16:07:03]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-09-11 16:07:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563663002/1

[commit-bot: I haz the power, 2014-09-11 18:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 18:25:28]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[James Cook, 2014-09-11 21:34:28]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-09-11 22:23:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563663002/20001

[commit-bot: I haz the power, 2014-09-11 23:40:13]

Committed patchset #2 (id:20001) as 1122a7702d6b369b054fd313b44b511099899313

[commit-bot: I haz the power, 2014-09-12 00:22:09]

Patchset 2 (id:??) landed as
https://crrev.com/646de7d89ca220cdd533bcd35f55768c1ad5dda1
Cr-Commit-Position: refs/heads/master@{#294493}