Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: extensions/common/permissions/socket_permission_unittest.cc

Issue 563663002: Clean up extensions permissions unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (permissions-data) fix android Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/socket_permission_unittest.cc
diff --git a/chrome/common/extensions/permissions/socket_permission_unittest.cc b/extensions/common/permissions/socket_permission_unittest.cc
similarity index 97%
rename from chrome/common/extensions/permissions/socket_permission_unittest.cc
rename to extensions/common/permissions/socket_permission_unittest.cc
index bcbeb97900c4f11842ea7f7a32451b7a955a6be9..0b1fae02dc954609b4d0034019ee5459662291ba 100644
--- a/chrome/common/extensions/permissions/socket_permission_unittest.cc
+++ b/extensions/common/permissions/socket_permission_unittest.cc
@@ -264,7 +264,7 @@ TEST(SocketPermissionTest, Match) {
TEST(SocketPermissionTest, IPC) {
const APIPermissionInfo* permission_info =
- PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
+ PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
{
IPC::Message m;
@@ -306,12 +306,10 @@ TEST(SocketPermissionTest, IPC) {
TEST(SocketPermissionTest, Value) {
const APIPermissionInfo* permission_info =
- PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
+ PermissionsInfo::GetInstance()->GetByID(APIPermission::kSocket);
- scoped_ptr<APIPermission> permission1(
- permission_info->CreateAPIPermission());
- scoped_ptr<APIPermission> permission2(
- permission_info->CreateAPIPermission());
+ scoped_ptr<APIPermission> permission1(permission_info->CreateAPIPermission());
+ scoped_ptr<APIPermission> permission2(permission_info->CreateAPIPermission());
scoped_ptr<base::ListValue> value(new base::ListValue());
value->AppendString("tcp-connect:*.example.com:80");
@@ -330,4 +328,3 @@ TEST(SocketPermissionTest, Value) {
} // namespace
} // namespace extensions
-

Powered by Google App Engine
This is Rietveld 408576698