Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 5634003: Fix PRIu64 in biosincludes.h (Closed)

Created:
10 years ago by Che-Liang Chiou
Modified:
9 years ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Fix PRIu64 in biosincludes.h Check /usr/include/inttypes.h; PRIu64 is defined as "llu" or "lu" without leading "%" character. Removing leading "%" character for compatibility. BUG=None TEST=Build successfully and run with u-boot and verify that outputs with PRIu64 are correct. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8a2d9c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M firmware/arch/arm/include/biosincludes.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/stub/include/biosincludes.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Che-Liang Chiou
10 years ago (2010-12-06 02:39:37 UTC) #1
Randall Spangler
10 years ago (2010-12-06 08:05:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698