Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 563083004: Add support for 'display' in Manifest. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_to_homescreen_manifest
Project:
chromium
Visibility:
Public.

Description

Add support for 'display' in Manifest. BUG=366145 Committed: https://crrev.com/f60720832599bc7306d9e37e3cef5ceee4c224ce Cr-Commit-Position: refs/heads/master@{#295438}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : typo #

Total comments: 1

Patch Set 4 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -32 lines) Patch
M content/common/manifest_manager_messages.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/manifest.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M content/public/common/manifest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 1 2 3 5 chunks +53 lines, -30 lines 0 comments Download
M content/renderer/manifest/manifest_parser_unittest.cc View 1 6 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mlamouri (slow - plz ping)
palmer@, can you look at the changes in: content/common/manifest_manager_messages.h avi@, can you look at the ...
6 years, 3 months ago (2014-09-17 13:36:09 UTC) #2
palmer
lgtm
6 years, 3 months ago (2014-09-17 19:21:23 UTC) #3
Avi (use Gerrit)
lgtm https://codereview.chromium.org/563083004/diff/40001/content/renderer/manifest/manifest_parser.cc File content/renderer/manifest/manifest_parser.cc (right): https://codereview.chromium.org/563083004/diff/40001/content/renderer/manifest/manifest_parser.cc#newcode38 content/renderer/manifest/manifest_parser.cc:38: } No {} here; you don't use it ...
6 years, 3 months ago (2014-09-18 02:00:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563083004/60001
6 years, 3 months ago (2014-09-18 07:44:40 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 7e4b676e2ab8394dd5f8024b6e634829446444af
6 years, 3 months ago (2014-09-18 08:54:22 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 08:57:42 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f60720832599bc7306d9e37e3cef5ceee4c224ce
Cr-Commit-Position: refs/heads/master@{#295438}

Powered by Google App Engine
This is Rietveld 408576698