content/public/common/manifest.cc - Issue 563083004: Add support for 'display' in Manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/manifest.cc

Issue 563083004: Add support for 'display' in Manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_to_homescreen_manifest

Patch Set: review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/manifest.cc

diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc

index f1dd57ece376c0f7c5a3fa1edcfa7944ba9731ac..d9fa2b26f25e4ea9780e6ce5e2fe2786a6d3f402 100644

--- a/content/public/common/manifest.cc

+++ b/content/public/common/manifest.cc

@@ -8,14 +8,18 @@ namespace content {

const size_t Manifest::kMaxIPCStringLength = 4 * 1024;

-Manifest::Manifest() {

+Manifest::Manifest()

+ : display(DISPLAY_MODE_UNSPECIFIED) {

}

Manifest::~Manifest() {

}

bool Manifest::IsEmpty() const {

- return name.is_null() && short_name.is_null();

+ return name.is_null() &&

+ short_name.is_null() &&

+ start_url.is_empty() &&

+ display == DISPLAY_MODE_UNSPECIFIED;

}

} // namespace content

« no previous file with comments | « content/public/common/manifest.h ('k') | content/renderer/manifest/manifest_parser.cc » ('j') | no next file with comments »