[Top Sites] Validating URLs for "redirects"

[Top Sites] Validating URLs for "redirects"

Redirects field in TopSitesDatabase is encoded as a space-seprated list
of URLs. But data URLS like "data:text/plain,this text  has space" adds
extra space, so that when decoded, non-URLs like "text" and "has" would
trigger DCHECK in URL() downstream, and crash debug Chrome.

This CL validates redirects URLs when they are read. It is not foolproof
(e.g., "data:text/plan,hidden http://extra.url"), but now we can ponder
how to best fix the root cause, without keeping the crashing bug around.

BUG=358034
Committed: https://crrev.com/1d8faa9c736dfabfe2b4120c6ca5eef48663199d
Cr-Commit-Position: refs/heads/master@{#296232}

[huangs, 2014-09-11 17:53:30]

huangs@chromium.org changed reviewers:
+ shess@chromium.org

[huangs, 2014-09-11 17:53:30]

PTAL at the simpler fix.

The more complex fix is https://codereview.chromium.org/560543002/ but it may
change drastically.

[huangs, 2014-09-15 17:04:22]

Ping shess@ for review.

[huangs, 2014-09-23 16:08:49]

huangs@chromium.org changed reviewers:
+ thestig@chromium.org
- shess@chromium.org

[huangs, 2014-09-23 16:09:13]

Changing reviewer to thestig@, since shess@ is on leave.  PTAL.

[Lei Zhang, 2014-09-23 17:20:23]

lgtm

[huangs, 2014-09-23 17:23:17]

Thanks! Submitting.

[huangs, 2014-09-23 17:23:20]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2014-09-23 17:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/562993002/1

[commit-bot: I haz the power, 2014-09-23 20:56:28]

Committed patchset #1 (id:1) as 5ed53b526b0eb829514266b6544c6e6a188708ac

[commit-bot: I haz the power, 2014-09-23 20:57:22]

Patchset 1 (id:??) landed as
https://crrev.com/1d8faa9c736dfabfe2b4120c6ca5eef48663199d
Cr-Commit-Position: refs/heads/master@{#296232}