[Top Sites] Validating URLs for "redirects"

chrome/browser/history/top_sites_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/top_sites_database.h"
 
 #include "base/files/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_split.h"
@@ skipping 72 matching lines @@
   std::vector<std::string> redirects;
   for (size_t i = 0; i < url.redirects.size(); i++)
     redirects.push_back(url.redirects[i].spec());
   return JoinString(redirects, ' ');
 }
 
 // Decodes redirects from a string and sets them for the url.
 void SetRedirects(const std::string& redirects, history::MostVisitedURL* url) {
   std::vector<std::string> redirects_vector;
   base::SplitStringAlongWhitespace(redirects, &redirects_vector);
-  for (size_t i = 0; i < redirects_vector.size(); ++i)
-    url->redirects.push_back(GURL(redirects_vector[i]));
+  for (size_t i = 0; i < redirects_vector.size(); ++i) {
+    GURL redirects_url(redirects_vector[i]);
+    if (redirects_url.is_valid())
+      url->redirects.push_back(redirects_url);
+  }
 }
 
 // Track various failure (and success) cases in recovery code.
 //
 // TODO(shess): The recovery code is complete, but by nature runs in challenging
 // circumstances, so initially the default error response is to leave the
 // existing database in place.  This histogram is intended to expose the
 // failures seen in the fleet.  Frequent failure cases can be explored more
 // deeply to see if the complexity to fix them is warranted.  Infrequent failure
 // cases can be resolved by marking the database unrecoverable (which will
@@ skipping 619 matching lines @@
                                     db.get(), db_name));
   db->set_page_size(4096);
   db->set_cache_size(32);
 
   if (!db->Open(db_name))
     return NULL;
   return db.release();
 }
 
 }  // namespace history