Make PasswordSyncableServiceTest.* more readable.

components/password_manager.gypi

Index: components/password_manager.gypi
diff --git a/components/password_manager.gypi b/components/password_manager.gypi
index 63d93d8f82ce527805faa2ac89925341e74b923f..6a0cdfbc4e799924b9ec9792d96a3d126611ad5f 100644
--- a/components/password_manager.gypi
+++ b/components/password_manager.gypi
@@ -75,6 +75,7 @@
             'password_manager_enable_sync%': 1,
           }],
         ],
+        'enable_wexit_time_destructors': 1,

[Ilya Sherman, 2014/09/12 21:33:29]

Please remove this, throughout.

[vasilii, 2014/09/15 08:45:38]

If you say that the static initializers are prohibited, it should be enforced
somehow. This check is already on for many chrome targets.

[Ilya Sherman, 2014/09/15 17:21:47]

Sorry, I read this boolean backward, so I thought this was disabling the warning
rather than enabling it.  Makes more sense now that I'm reading it correctly :)

However, it seems quite odd to add the warning here, rather than in a
higher-level file.  This seems like the sort of setting that should be set
globally, or not at all.  I'd prefer that you not add this flag in this CL; and
follow up by checking with someone familiar with the build system -- say, thakis
or brettw -- and get their thoughts on the best path forward.

[vasilii, 2014/09/16 08:45:02]

Done.

       },
       'conditions': [
         ['OS=="mac"', {
@@ -119,6 +120,9 @@
       'include_dirs': [
         '..',
       ],
+      'variables': {
+        'enable_wexit_time_destructors': 1,
+      },
       'sources': [
         # Note: sources list duplicated in GN build.
         'password_manager/core/browser/mock_password_store.cc',
@@ -142,6 +146,9 @@
       'include_dirs': [
         '..',
       ],
+      'variables': {
+        'enable_wexit_time_destructors': 1,
+      },
       'sources': [
         # Note: sources list duplicated in GN build.
         'password_manager/core/common/password_manager_pref_names.cc',
@@ -170,6 +177,9 @@
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             'password_manager/content/common/credential_manager_message_generator.cc',
             'password_manager/content/common/credential_manager_message_generator.h',
@@ -193,6 +203,9 @@
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             'password_manager/content/renderer/credential_manager_client.cc',
             'password_manager/content/renderer/credential_manager_client.h',
@@ -218,6 +231,9 @@
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             # Note: sources list duplicated in GN build.
             'password_manager/content/browser/content_password_manager_driver.cc',