Make PasswordSyncableServiceTest.* more readable.

components/password_manager.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/password_manager/core/browser
       'target_name': 'password_manager_core_browser',
       'type': 'static_library',
@@ skipping 57 matching lines @@
       ],
       'variables': {
         'conditions': [
           ['android_webview_build == 1', {
             # Android WebView doesn't support sync.
             'password_manager_enable_sync%': 0,
           }, {
             'password_manager_enable_sync%': 1,
           }],
         ],
+        'enable_wexit_time_destructors': 1,

[Ilya Sherman, 2014/09/12 21:33:29]

Please remove this, throughout.

[vasilii, 2014/09/15 08:45:38]

If you say that the static initializers are prohibited, it should be enforced
somehow. This check is already on for many chrome targets.

[Ilya Sherman, 2014/09/15 17:21:47]

Sorry, I read this boolean backward, so I thought this was disabling the warning
rather than enabling it.  Makes more sense now that I'm reading it correctly :)

However, it seems quite odd to add the warning here, rather than in a
higher-level file.  This seems like the sort of setting that should be set
globally, or not at all.  I'd prefer that you not add this flag in this CL; and
follow up by checking with someone familiar with the build system -- say, thakis
or brettw -- and get their thoughts on the best path forward.

[vasilii, 2014/09/16 08:45:02]

Done.

       },
       'conditions': [
         ['OS=="mac"', {
           'sources!': [
             # TODO(blundell): Provide the iOS login DB implementation and then
             # also exclude the POSIX one from iOS. http://crbug.com/341429
             'password_manager/core/browser/login_database_posix.cc',
           ],
         }],
         ['password_manager_enable_sync == 1', {
@@ skipping 24 matching lines @@
       'type': 'static_library',
       'dependencies': [
         'autofill_core_common',
         '../base/base.gyp:base',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
       ],
       'include_dirs': [
         '..',
       ],
+      'variables': {
+        'enable_wexit_time_destructors': 1,
+      },
       'sources': [
         # Note: sources list duplicated in GN build.
         'password_manager/core/browser/mock_password_store.cc',
         'password_manager/core/browser/mock_password_store.h',
         'password_manager/core/browser/password_form_data.cc',
         'password_manager/core/browser/password_form_data.h',
         'password_manager/core/browser/stub_password_manager_client.cc',
         'password_manager/core/browser/stub_password_manager_client.h',
         'password_manager/core/browser/stub_password_manager_driver.cc',
         'password_manager/core/browser/stub_password_manager_driver.h',
         'password_manager/core/browser/test_password_store.cc',
         'password_manager/core/browser/test_password_store.h',
       ],
     },
     {
       # GN version: //components/password_manager/core/common
       'target_name': 'password_manager_core_common',
       'type': 'static_library',
       'dependencies': [
       ],
       'include_dirs': [
         '..',
       ],
+      'variables': {
+        'enable_wexit_time_destructors': 1,
+      },
       'sources': [
         # Note: sources list duplicated in GN build.
         'password_manager/core/common/password_manager_pref_names.cc',
         'password_manager/core/common/password_manager_pref_names.h',
         'password_manager/core/common/password_manager_switches.cc',
         'password_manager/core/common/password_manager_switches.h',
         'password_manager/core/common/password_manager_ui.cc',
         'password_manager/core/common/password_manager_ui.h',
       ],
     },
   ],
   'conditions': [
     ['OS != "ios"', {
       'targets': [
         {
           # GN version: //components/password_manager/content/common
           'target_name': 'password_manager_content_common',
           'type': 'static_library',
           'dependencies': [
             '../base/base.gyp:base',
             '../content/content.gyp:content_common',
             '../ipc/ipc.gyp:ipc',
             '../third_party/WebKit/public/blink.gyp:blink_minimal',
             'password_manager_core_common',
           ],
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             'password_manager/content/common/credential_manager_message_generator.cc',
             'password_manager/content/common/credential_manager_message_generator.h',
             'password_manager/content/common/credential_manager_messages.h',
             'password_manager/content/common/credential_manager_types.cc',
             'password_manager/content/common/credential_manager_types.h',
           ],
         },
         {
           # GN version: //components/password_manager/content/renderer
           'target_name': 'password_manager_content_renderer',
           'type': 'static_library',
           'dependencies': [
             '../base/base.gyp:base',
             '../content/content.gyp:content_common',
             '../ipc/ipc.gyp:ipc',
             '../third_party/WebKit/public/blink.gyp:blink',
             'password_manager_core_common',
             'password_manager_content_common',
           ],
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             'password_manager/content/renderer/credential_manager_client.cc',
             'password_manager/content/renderer/credential_manager_client.h',
           ],
         },
         {
           # GN version: //components/password_manager/content/browser
           'target_name': 'password_manager_content_browser',
           'type': 'static_library',
           'dependencies': [
             '../base/base.gyp:base',
             '../content/content.gyp:content_browser',
             '../content/content.gyp:content_common',
             '../ipc/ipc.gyp:ipc',
             '../net/net.gyp:net',
             'autofill_content_browser',
             'autofill_content_common',
             'autofill_core_common',
             'keyed_service_content',
             'password_manager_core_browser',
             'password_manager_content_common',
           ],
           'include_dirs': [
             '..',
           ],
+          'variables': {
+            'enable_wexit_time_destructors': 1,
+          },
           'sources': [
             # Note: sources list duplicated in GN build.
             'password_manager/content/browser/content_password_manager_driver.cc',
             'password_manager/content/browser/content_password_manager_driver.h',
             'password_manager/content/browser/password_manager_internals_service_factory.cc',
             'password_manager/content/browser/password_manager_internals_service_factory.h',
           ],
         },
       ],
     }],
   ],
 }