Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 562513004: Remove FramelessScrollView. (Closed)

Created:
6 years, 3 months ago by skobes
Modified:
6 years, 3 months ago
CC:
blink-reviews, dcheng, dsinclair
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove FramelessScrollView. This class was only used for rendering <select> elements. PopupListBox now inherits ScrollView directly. (With future refactorings of the scrolling code it may not even do that.) PopupContainer now inherits Widget. There is no need for it to be a ScrollView since it never actually scrolls. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181769

Patch Set 1 #

Patch Set 2 : Fix Windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -325 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/platform/scroll/FramelessScrollView.h View 1 chunk +0 lines, -94 lines 0 comments Download
D Source/platform/scroll/FramelessScrollView.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
D Source/platform/scroll/FramelessScrollViewClient.h View 1 chunk +0 lines, -47 lines 0 comments Download
M Source/web/PopupContainer.h View 3 chunks +25 lines, -10 lines 0 comments Download
M Source/web/PopupContainer.cpp View 10 chunks +26 lines, -15 lines 0 comments Download
A + Source/web/PopupContainerClient.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M Source/web/PopupListBox.h View 7 chunks +35 lines, -23 lines 0 comments Download
M Source/web/PopupListBox.cpp View 8 chunks +55 lines, -10 lines 0 comments Download
M Source/web/PopupMenuChromium.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebPopupMenuImpl.h View 5 chunks +8 lines, -9 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
skobes
6 years, 3 months ago (2014-09-10 19:12:41 UTC) #2
eseidel
lgtm Great.
6 years, 3 months ago (2014-09-10 19:27:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/562513004/20001
6 years, 3 months ago (2014-09-10 20:57:36 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 22:06:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181769

Powered by Google App Engine
This is Rietveld 408576698