Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: Source/web/WebPopupMenuImpl.h

Issue 562513004: Remove FramelessScrollView. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix Windows build. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/PopupMenuChromium.cpp ('k') | Source/web/WebPopupMenuImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebPopupMenuImpl.h
diff --git a/Source/web/WebPopupMenuImpl.h b/Source/web/WebPopupMenuImpl.h
index c47e3bf30868df3ee4568937f55bbe1ff54793fe..683822e9788e1acc209a0e5e6ac3a52a4f660949 100644
--- a/Source/web/WebPopupMenuImpl.h
+++ b/Source/web/WebPopupMenuImpl.h
@@ -31,17 +31,16 @@
#ifndef WebPopupMenuImpl_h
#define WebPopupMenuImpl_h
-#include "platform/scroll/FramelessScrollViewClient.h"
#include "public/platform/WebContentLayerClient.h"
#include "public/platform/WebPoint.h"
#include "public/platform/WebSize.h"
#include "public/web/WebPopupMenu.h"
+#include "web/PopupContainerClient.h"
#include "wtf/OwnPtr.h"
#include "wtf/RefCounted.h"
namespace blink {
class LocalFrame;
-class FramelessScrollView;
class KeyboardEvent;
class Page;
class PlatformKeyboardEvent;
@@ -57,7 +56,7 @@ class WebTouchEvent;
class Widget;
struct WebRect;
-class WebPopupMenuImpl : public WebPopupMenu, public FramelessScrollViewClient, public WebContentLayerClient, public RefCounted<WebPopupMenuImpl> {
+class WebPopupMenuImpl : public WebPopupMenu, public PopupContainerClient, public WebContentLayerClient, public RefCounted<WebPopupMenuImpl> {
WTF_MAKE_FAST_ALLOCATED;
public:
// WebWidget functions:
@@ -92,7 +91,7 @@ public:
WebContentLayerClient::GraphicsContextStatus = GraphicsContextEnabled) OVERRIDE FINAL;
// WebPopupMenuImpl
- void initialize(FramelessScrollView* widget, const WebRect& bounds);
+ void initialize(PopupContainer* widget, const WebRect& bounds);
WebWidgetClient* client() { return m_client; }
@@ -120,8 +119,8 @@ public:
virtual IntRect rootViewToScreen(const IntRect&) const OVERRIDE FINAL;
virtual WebScreenInfo screenInfo() const OVERRIDE FINAL;
- // FramelessScrollViewClient methods:
- virtual void popupClosed(FramelessScrollView*) OVERRIDE FINAL;
+ // PopupContainerClient methods:
+ virtual void popupClosed(PopupContainer*) OVERRIDE FINAL;
WebWidgetClient* m_client;
WebSize m_size;
@@ -133,13 +132,13 @@ public:
// This is a non-owning ref. The popup will notify us via popupClosed()
// before it is destroyed.
- FramelessScrollView* m_widget;
+ PopupContainer* m_widget;
};
DEFINE_TYPE_CASTS(WebPopupMenuImpl, WebWidget, widget, widget->isPopupMenu(), widget.isPopupMenu());
-// WebPopupMenuImpl is the only implementation of FramelessScrollViewClient, so
+// WebPopupMenuImpl is the only implementation of PopupContainerClient, so
// no need for further checking.
-DEFINE_TYPE_CASTS(WebPopupMenuImpl, FramelessScrollViewClient, client, true, true);
+DEFINE_TYPE_CASTS(WebPopupMenuImpl, PopupContainerClient, client, true, true);
} // namespace blink
« no previous file with comments | « Source/web/PopupMenuChromium.cpp ('k') | Source/web/WebPopupMenuImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698