components/gcm_driver/gcm_driver.h - Issue 562423002: Clear GCM data when the user clears cookies and other site data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 562423002: Clear GCM data when the user clears cookies and other site data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ExtensionBrowsingDataTest tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_profile_service.cc ('K') | « components/gcm_driver/fake_gcm_driver.cc ('k') | components/gcm_driver/gcm_driver_android.h » ('j') | components/gcm_driver/gcm_driver_desktop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_driver.h

diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h

index c10d9f16769ddfc445e1ce1c9a2a16b7fad7469a..f13d3f30881661f5beecd990de63228954848aaa 100644

--- a/components/gcm_driver/gcm_driver.h

+++ b/components/gcm_driver/gcm_driver.h

@@ -72,9 +72,10 @@ class GCMDriver {

// been called, no other GCMDriver methods may be used.

virtual void Shutdown();

- // Call this method when the user signs in to a GAIA account.

+ // Call this method when the user signs in to or out of a GAIA account.

// TODO(jianli): To be removed when sign-in enforcement is dropped.

fgorski 2014/09/12 20:15:53 do you need the todo?

jianli 2014/09/12 22:13:10 Removed. The original comment was not exactly righ

virtual void OnSignedIn() = 0;

+ virtual void OnSignedOut() = 0;

// Removes all the cached and persisted GCM data. If the GCM service is

// restarted after the purge, a new Android ID will be obtained.