chrome/browser/services/gcm/gcm_profile_service.cc - Issue 562423002: Clear GCM data when the user clears cookies and other site data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 562423002: Clear GCM data when the user clears cookies and other site data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ExtensionBrowsingDataTest tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_test.cc ('k') | components/gcm_driver/fake_gcm_driver.h » ('j') | components/gcm_driver/gcm_driver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_profile_service.cc

diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc

index 0539acc212bc5dcee3ad535f239acc9b35705254..ad0e1f42cbaafdb91e2ba4c6bdda53313c6ec778 100644

--- a/chrome/browser/services/gcm/gcm_profile_service.cc

+++ b/chrome/browser/services/gcm/gcm_profile_service.cc

@@ -116,9 +116,9 @@ void GCMProfileService::IdentityObserver::OnActiveAccountLogout() {

// Check is necessary to not crash browser_tests.

if (gcm_account_tracker_)

gcm_account_tracker_->Stop();

- // TODO(fgorski): If we purge here, what should happen when we get

- // OnActiveAccountLogin() right after that?

- driver_->Purge();

+ // OnSignedOut will also clear all the GCM data. If the user signs in again,

+ // a new GCM ID will be retrieved.

+ driver_->OnSignedOut();

fgorski 2014/09/12 20:15:53 If we are not changing Device Id in this case, ple

jianli 2014/09/12 22:13:10 Updated the comment.

}

std::string GCMProfileService::IdentityObserver::SignedInUserName() const {