Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 562423002: Clear GCM data when the user clears cookies and other site data (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer, fgorski
CC:
chromium-reviews, markusheintz_, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clear GCM data when the user clears cookies and other site data This is needed for the work to drop GCM sign-in enforcement. Since we no longer wipe out the GCM data when the user signs out, we need to give user a chance to clear the data if he or she wants. BUG=384041 TEST=Manual test by selecting "Cookies and other site and plugin data" Committed: https://crrev.com/6967652cefa1e306d21e70d4a12dcc0ac572c28b Cr-Commit-Position: refs/heads/master@{#294754}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Sync #

Patch Set 4 : Fix ExtensionBrowsingDataTest tests #

Total comments: 6

Patch Set 5 : Sync #

Patch Set 6 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -20 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 2 3 1 chunk +11 lines, -9 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 2 3 4 5 2 chunks +9 lines, -5 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 1 2 3 4 5 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
jianli
bauerb for all browsing data changes. fgorski for all GCM changes.
6 years, 3 months ago (2014-09-11 21:59:45 UTC) #2
Bernhard Bauer
browsing_data LGTM
6 years, 3 months ago (2014-09-12 08:43:21 UTC) #3
jianli
bauerb, could you please take one more change to browsing_data_test.cc in order to fix extension ...
6 years, 3 months ago (2014-09-12 18:24:24 UTC) #4
fgorski
Purge should be optional. https://codereview.chromium.org/562423002/diff/60001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/562423002/diff/60001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode121 chrome/browser/services/gcm/gcm_profile_service.cc:121: driver_->OnSignedOut(); If we are not ...
6 years, 3 months ago (2014-09-12 20:15:53 UTC) #5
jianli
https://codereview.chromium.org/562423002/diff/60001/chrome/browser/services/gcm/gcm_profile_service.cc File chrome/browser/services/gcm/gcm_profile_service.cc (right): https://codereview.chromium.org/562423002/diff/60001/chrome/browser/services/gcm/gcm_profile_service.cc#newcode121 chrome/browser/services/gcm/gcm_profile_service.cc:121: driver_->OnSignedOut(); On 2014/09/12 20:15:53, fgorski wrote: > If we ...
6 years, 3 months ago (2014-09-12 22:13:10 UTC) #6
fgorski
lgtm
6 years, 3 months ago (2014-09-13 04:14:18 UTC) #7
Bernhard Bauer
Still LGTM
6 years, 3 months ago (2014-09-13 10:58:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562423002/100001
6 years, 3 months ago (2014-09-13 18:46:32 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001) as b04508938be551641f9d0f0a60203abc5aa7c65c
6 years, 3 months ago (2014-09-13 20:46:56 UTC) #11
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/6967652cefa1e306d21e70d4a12dcc0ac572c28b Cr-Commit-Position: refs/heads/master@{#294754}
6 years, 3 months ago (2014-09-13 20:53:38 UTC) #12
jianli
6 years, 2 months ago (2014-09-26 18:37:12 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/608813003/ by jianli@chromium.org.

The reason for reverting is: We're not longer doing this..

Powered by Google App Engine
This is Rietveld 408576698