Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.cc

Issue 562423002: Clear GCM data when the user clears cookies and other site data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc
index 0539acc212bc5dcee3ad535f239acc9b35705254..069862d58cf78f7acdf4c69e1f8f47a3487b3e94 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service.cc
@@ -116,9 +116,11 @@ void GCMProfileService::IdentityObserver::OnActiveAccountLogout() {
// Check is necessary to not crash browser_tests.
if (gcm_account_tracker_)
gcm_account_tracker_->Stop();
- // TODO(fgorski): If we purge here, what should happen when we get
- // OnActiveAccountLogin() right after that?
- driver_->Purge();
+ // When sign-in enforcement is not dropped, OnSignedOut will also clear all
+ // the GCM data and a new GCM ID will be retrieved after the user signs in
+ // again. Otherwise, the user sign-out will not affect the existing GCM
+ // data.
+ driver_->OnSignedOut();
}
std::string GCMProfileService::IdentityObserver::SignedInUserName() const {
« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_test.cc ('k') | components/gcm_driver/fake_gcm_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698