Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 562343002: Revert of Reenable DevToolsSanityTest.TestDeviceEmulation. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable DevToolsSanityTest.TestDeviceEmulation. (patchset #1 id:1 of https://codereview.chromium.org/564763002/) Reason for revert: Fails on the main waterfall on Windows and Linux: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(2)/builds/22510 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/33246 Original issue's description: > Reenable DevToolsSanityTest.TestDeviceEmulation. > > BUG=397889 > TBR=pfeldman@chromium.org > > Committed: https://crrev.com/8844a8eba4465ff5f66bff5b7db195a0192625c3 > Cr-Commit-Position: refs/heads/master@{#294375} TBR=pfeldman@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=397889 Committed: https://crrev.com/96e8a26d07980ed7314c9784208e4a30bdc8f10d Cr-Commit-Position: refs/heads/master@{#294431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nasko
Created Revert of Reenable DevToolsSanityTest.TestDeviceEmulation.
6 years, 3 months ago (2014-09-11 18:35:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562343002/1
6 years, 3 months ago (2014-09-11 18:40:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5bede5121a22cf89cbc57c92c3e3e4ea48c17d21
6 years, 3 months ago (2014-09-11 18:44:08 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 19:09:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96e8a26d07980ed7314c9784208e4a30bdc8f10d
Cr-Commit-Position: refs/heads/master@{#294431}

Powered by Google App Engine
This is Rietveld 408576698