Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 562343002: Revert of Reenable DevToolsSanityTest.TestDeviceEmulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 772 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 #if defined(OS_WIN) 783 #if defined(OS_WIN)
784 // Flaking on windows swarm try runs: crbug.com/409285. 784 // Flaking on windows swarm try runs: crbug.com/409285.
785 #define MAYBE_TestConsoleOnNavigateBack DISABLED_TestConsoleOnNavigateBack 785 #define MAYBE_TestConsoleOnNavigateBack DISABLED_TestConsoleOnNavigateBack
786 #else 786 #else
787 #define MAYBE_TestConsoleOnNavigateBack TestConsoleOnNavigateBack 787 #define MAYBE_TestConsoleOnNavigateBack TestConsoleOnNavigateBack
788 #endif 788 #endif
789 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, MAYBE_TestConsoleOnNavigateBack) { 789 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, MAYBE_TestConsoleOnNavigateBack) {
790 RunTest("testConsoleOnNavigateBack", kNavigateBackTestPage); 790 RunTest("testConsoleOnNavigateBack", kNavigateBackTestPage);
791 } 791 }
792 792
793 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDeviceEmulation) { 793 // https://crbug.com/397889
794 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, DISABLED_TestDeviceEmulation) {
794 RunTest("testDeviceMetricsOverrides", "about:blank"); 795 RunTest("testDeviceMetricsOverrides", "about:blank");
795 } 796 }
796 797
797 798
798 // Tests that external navigation from inspector page is always handled by 799 // Tests that external navigation from inspector page is always handled by
799 // DevToolsWindow and results in inspected page navigation. 800 // DevToolsWindow and results in inspected page navigation.
800 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsExternalNavigation) { 801 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestDevToolsExternalNavigation) {
801 OpenDevToolsWindow(kDebuggerTestPage, true); 802 OpenDevToolsWindow(kDebuggerTestPage, true);
802 GURL url = test_server()->GetURL(kNavigateBackTestPage); 803 GURL url = test_server()->GetURL(kNavigateBackTestPage);
803 ui_test_utils::UrlLoadObserver observer(url, 804 ui_test_utils::UrlLoadObserver observer(url,
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 916
916 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, RemoteDebugger) { 917 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, RemoteDebugger) {
917 #if defined(OS_WIN) && defined(USE_ASH) 918 #if defined(OS_WIN) && defined(USE_ASH)
918 // Disable this test in Metro+Ash for now (http://crbug.com/262796). 919 // Disable this test in Metro+Ash for now (http://crbug.com/262796).
919 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests)) 920 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
920 return; 921 return;
921 #endif 922 #endif
922 923
923 ASSERT_TRUE(RunExtensionTest("target_list")) << message_; 924 ASSERT_TRUE(RunExtensionTest("target_list")) << message_;
924 } 925 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698