Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 562253002: Arrow functions: Cleanup handling of the prototype property (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
Reviewers:
aperez, rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Arrow functions: Cleanup handling of the prototype property The old code did not work correctly in case of optimizations. I found this out when implementing concise methods and we now plumb through the function kind so we know what kind of Map to create for the function. BUG=v8:2700 LOG=y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23920

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/arrow-functions.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-11 16:21:55 UTC) #2
aperez
On 2014/09/11 16:21:55, arv wrote: Looks good to me.
6 years, 3 months ago (2014-09-12 02:37:08 UTC) #3
rossberg
lgtm
6 years, 3 months ago (2014-09-12 12:29:16 UTC) #4
arv (Not doing code reviews)
6 years, 3 months ago (2014-09-12 15:07:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698