src/factory.cc - Issue 562253002: Arrow functions: Cleanup handling of the prototype property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 562253002: Arrow functions: Cleanup handling of the prototype property (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index f931b7fb620fffe786793ce383d3148b7ff717a4..5303dd0cc25f6e1bf63f8dda30f833f5d0562af9 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1237,10 +1237,6 @@ void Factory::InitializeFunction(Handle<JSFunction> function,

function->set_prototype_or_initial_map(*the_hole_value());

function->set_literals_or_bindings(*empty_fixed_array());

function->set_next_function_link(*undefined_value());

- // TODO(arv): This does not look correct. We need to make sure we use

- // a Map that has no prototype property.

- if (info->is_arrow()) function->RemovePrototype();

}

« no previous file with comments | « src/contexts.h ('k') | test/mjsunit/harmony/arrow-functions.js » ('j') | no next file with comments »