Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 562023003: Revert of Fix some more for= usage. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix some more for= usage. (patchset #7 id:120001 of https://codereview.chromium.org/539383003/) Reason for revert: breaks linux_chromeos on try runs here and on buildbot Original issue's description: > Fix some more for= usage. > > Also fix some controlled settings indicators. > > BUG=409938 > R=dbeam@chromium.org > > Committed: https://crrev.com/ce80b519af00bb6259e8c63f91fee5263d818124 > Cr-Commit-Position: refs/heads/master@{#294681} TBR=dbeam@chromium.org,estade@chromium.org NOTREECHECKS=true NOTRY=true BUG=409938 Committed: https://crrev.com/5a4ccee21258b2a6266375d194149ba27e80b3f7 Cr-Commit-Position: refs/heads/master@{#294765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -400 lines) Patch
M chrome/browser/resources/options/browser_options.html View 25 chunks +121 lines, -163 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 10 chunks +102 lines, -149 lines 0 comments Download
M chrome/browser/resources/options/controlled_setting.css View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/resources/options/home_page_overlay.html View 1 chunk +23 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/hotword_confirm_overlay.html View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 2 chunks +15 lines, -25 lines 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.html View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.html View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/startup_section.html View 1 chunk +9 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Fix some more for= usage.
6 years, 3 months ago (2014-09-14 06:12:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562023003/1
6 years, 3 months ago (2014-09-14 06:13:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 154a1371c702c01faf4ea991f5124c4a3879844d
6 years, 3 months ago (2014-09-14 06:15:38 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-14 06:21:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4ccee21258b2a6266375d194149ba27e80b3f7
Cr-Commit-Position: refs/heads/master@{#294765}

Powered by Google App Engine
This is Rietveld 408576698