Issue 561733003: Remove direct Host creation from RebaselineServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 561733003: Remove direct Host creation from RebaselineServer. (Closed)

Created:
6 years, 3 months ago by elecro

Modified:
6 years, 3 months ago

Reviewers:
Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove direct Host creation from RebaselineServer. Remove Host() call from RebaselineServer. The host object is passed to the RebaselineServer from outside. This could help with the Mocking as the FIXME mentioned. BUG=None TEST=test-webkitpy Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181893

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -17 lines)			Patch
M	Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561733003/1

6 years, 3 months ago (2014-09-12 11:05:40 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-12 12:06:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181893

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages