Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py - Issue 561733003: Remove direct Host creation from RebaselineServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

Issue 561733003: Remove direct Host creation from RebaselineServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py ('k') | Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

diff --git a/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py b/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

index 9e9c379d6b055895e13015848187ed99f7132907..cdbb7599f96bd0db1d9c99b0f9a1875858828a46 100644

--- a/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

+++ b/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py

@@ -31,7 +31,6 @@ import os

import os.path

import BaseHTTPServer

-from webkitpy.common.host import Host # FIXME: This should not be needed!

from webkitpy.layout_tests.port.base import Port

from webkitpy.tool.servers.reflectionhandler import ReflectionHandler

@@ -175,11 +174,7 @@ def get_test_baselines(test_file, test_config):

return self._platforms_by_directory[directory]

test_path = test_config.filesystem.join(test_config.layout_tests_directory, test_file)

- # FIXME: This should get the Host from the test_config to be mockable!

- host = Host()

- host.initialize_scm()

- host.filesystem = test_config.filesystem

+ host = test_config.host

all_platforms_port = AllPlatformsPort(host)

all_test_baselines = {}