Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 561653002: [blink-in-js] Migrate resources required for blink-in-js to grd - part 2 (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[blink-in-js] Migrate resources required for blink-in-js to grd - part 2 Remove all the embedded resources from blink and migrate to using grd generated pak files BUG=312586 R=haraken@chromium.org, jochen@chromium.org NOTRY=true Part 1: https://codereview.chromium.org/558933002 Part 3: https://codereview.chromium.org/560763002 Committed: https://crrev.com/7c56c17aa2b0715dfd3f3f5169b5fba5159aedd3 Cr-Commit-Position: refs/heads/master@{#294202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-10 05:45:57 UTC) #2
vivekg
@jochen, I am trying to autogenerate this resource map so we can get rid of ...
6 years, 3 months ago (2014-09-10 06:00:58 UTC) #3
haraken
LGTM
6 years, 3 months ago (2014-09-10 07:20:30 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-10 07:36:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/561653002/1
6 years, 3 months ago (2014-09-10 13:39:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/561653002/1
6 years, 3 months ago (2014-09-10 18:52:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as e793f8e96fc73ac18c094b82fb14bdb54e481dac
6 years, 3 months ago (2014-09-10 18:55:25 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 19:19:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c56c17aa2b0715dfd3f3f5169b5fba5159aedd3
Cr-Commit-Position: refs/heads/master@{#294202}

Powered by Google App Engine
This is Rietveld 408576698