Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 558933002: [blink-in-js] Migrate resources required for blink-in-js to grd - part 1 (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[blink-in-js] Migrate resources required for blink-in-js to grd - part 1 Remove all the embedded resources from blink and migrate to using grd generated pak files. BUG=312586 R=haraken@chromium.org, jochen@chromium.org Part 2: https://codereview.chromium.org/561653002 Part 3: https://codereview.chromium.org/560763002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public/blink_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-10 05:29:47 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-10 07:20:20 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-10 07:36:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/558933002/1
6 years, 3 months ago (2014-09-10 07:43:19 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 08:46:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181714

Powered by Google App Engine
This is Rietveld 408576698