Adding unit tests for the SafeBrowsingBlockingPage class

This CL adds unit-tests for the SafeBrowsingBlockingPage class.
This required:
- creating a factory to create SafeBrowsingBlockingPage
  instances (so unit-tests can provide their own sub-classes).
- making the code posts tasks on the current message loop
  when there is no IO thread.  This should only happen in
  tests scenarios where we only have 1 thread.

BUG=6731
TEST=Run the unit-tests. In Chrome, navigate to pages flagged as malware (ex: ianfette.org) and make sure the safe browsing feature still works as expected.

     

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13088

[Paul Godavari, 2009-04-01 22:01:23]

LGTM with some comments. Thanks very much for creating these tests!

http://codereview.chromium.org/56135/diff/2012/2017
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

http://codereview.chromium.org/56135/diff/2012/2017#newcode77
Line 77: const UnsafeResourceList& unsafe_resources);
Maybe make this method protected so it can be used by the sub class and friends?

http://codereview.chromium.org/56135/diff/2012/2021
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

http://codereview.chromium.org/56135/diff/2012/2021#newcode11
Line 11: static const char* kGoogleURL = "http://www.google.com/";
I'm not familiar with NavigationController... will these URLs actually get
loaded? If so, it's probably not a good idea to depend on real URLs that may or
may not be available when the test runs. Maybe use testserver.py?

[jcampan, 2009-04-02 07:11:11]

http://codereview.chromium.org/56135/diff/2012/2017
File chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

http://codereview.chromium.org/56135/diff/2012/2017#newcode77
Line 77: const UnsafeResourceList& unsafe_resources);
On 2009/04/01 22:01:23, Paul Godavari wrote:
> Maybe make this method protected so it can be used by the sub class and
friends?
I am not following you, it is protected.

http://codereview.chromium.org/56135/diff/2012/2021
File chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
(right):

http://codereview.chromium.org/56135/diff/2012/2021#newcode11
Line 11: static const char* kGoogleURL = "http://www.google.com/";
On 2009/04/01 22:01:23, Paul Godavari wrote:
> I'm not familiar with NavigationController... will these URLs actually get
> loaded? If so, it's probably not a good idea to depend on real URLs that may
or
> may not be available when the test runs. Maybe use testserver.py?
These URLs are arbitrary and are never loaded.
The navigation controller calls on the RVH to load the URL, but in these tests
the RVH is mocked and does not do anything.
So we should be OK.