Adding unit tests for the SafeBrowsingBlockingPage class

chrome/browser/safe_browsing/safe_browsing_blocking_page.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Classes for managing the SafeBrowsing interstitial pages.
 //
 // When a user is about to visit a page the SafeBrowsing system has deemed to
 // be malicious, either as malware or a phishing page, we show an interstitial
 // page with some options (go back, continue) to give the user a chance to avoid
 // the harmful page.
@@ skipping 20 matching lines @@
 #include <map>
 #include <vector>
 
 #include "chrome/browser/tab_contents/interstitial_page.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "googleurl/src/gurl.h"
 
 class DictionaryValue;
 class MessageLoop;
 class NavigationController;
+class SafeBrowsingBlockingPageFactory;
 class WebContents;
 
-
 class SafeBrowsingBlockingPage : public InterstitialPage {
  public:
   virtual ~SafeBrowsingBlockingPage();
 
   // Shows a blocking page warning the user about phishing/malware for a
   // specific resource.
   // You can call this method several times, if an interstitial is already
   // showing, the new one will be queued and displayed if the user decides
   // to proceed on the currently showing interstitial.
   static void ShowBlockingPage(
       SafeBrowsingService* service,
       const SafeBrowsingService::UnsafeResource& resource);
 
+  // Makes the passed |factory| the factory used to instanciate
+  // SafeBrowsingBlockingPage objects. Usefull for tests.
+  static void RegisterFactory(SafeBrowsingBlockingPageFactory* factory) {
+    factory_ = factory;
+  }
+
   // InterstitialPage method:
   virtual std::string GetHTMLContents();
   virtual void Proceed();
   virtual void DontProceed();
 
+  typedef std::vector<SafeBrowsingService::UnsafeResource> UnsafeResourceList;
+
  protected:
   // InterstitialPage method:
   virtual void CommandReceived(const std::string& command);
 
- private:
-  typedef std::vector<SafeBrowsingService::UnsafeResource> UnsafeResourceList;
-
   // Don't instanciate this class directly, use ShowBlockingPage instead.
   SafeBrowsingBlockingPage(SafeBrowsingService* service,
                            WebContents* web_contents,
                            const UnsafeResourceList& unsafe_resources);
 
+ private:
   // Fills the passed dictionary with the strings passed to JS Template when
   // creating the HTML.
   void PopulateMultipleThreatStringDictionary(DictionaryValue* strings);
   void PopulateMalwareStringDictionary(DictionaryValue* strings);
   void PopulatePhishingStringDictionary(DictionaryValue* strings);
 
   // A helper method used by the Populate methods above used to populate common
   // fields.
   void PopulateStringDictionary(DictionaryValue* strings,
                                 const std::wstring& title,
@@ skipping 12 matching lines @@
   // Notifies the SafeBrowsingService on the IO thread whether to proceed or not
   // for the |resources|.
   static void NotifySafeBrowsingService(SafeBrowsingService* sb_service,
                                         const UnsafeResourceList& resources,
                                         bool proceed);
 
   // Returns true if the passed |unsafe_resources| is for the main page.
   static bool IsMainPage(const UnsafeResourceList& unsafe_resources);
 
  private:
+  friend class SafeBrowsingBlockingPageFactoryImpl;
+
   // For reporting back user actions.
   SafeBrowsingService* sb_service_;
   MessageLoop* report_loop_;
 
   // Whether the flagged resource is the main page (or a sub-resource is false).
   bool is_main_frame_;
 
   // The index of a navigation entry that should be removed when DontProceed()
   // is invoked, -1 if not entry should be removed.
   int navigation_entry_index_to_remove_;
 
   // The list of unsafe resources this page is warning about.
   UnsafeResourceList unsafe_resources_;
 
+  // The factory used to instanciate SafeBrowsingBlockingPage objects.
+  // Usefull for tests, so they can provide their own implementation of
+  // SafeBrowsingBlockingPage.
+  static SafeBrowsingBlockingPageFactory* factory_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPage);
 };
 
+// Factory for creating SafeBrowsingBlockingPage.  Useful for tests.
+class SafeBrowsingBlockingPageFactory {
+ public:
+  ~SafeBrowsingBlockingPageFactory() { }
+
+  virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
+      SafeBrowsingService* service,
+      WebContents* web_contents,
+      const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) = 0;
+};
+
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_