Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 561293004: check vm and dartium before update (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

check vm and dartium before update BUG=dartbug.com/17018 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40553

Patch Set 1 #

Patch Set 2 : merge and revise check #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M editor/tools/plugins/com.google.dart.tools.update.core/src/com/google/dart/tools/update/core/internal/jobs/InstallUpdateAction.java View 1 3 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
6 years, 3 months ago (2014-09-12 04:54:52 UTC) #2
pquitslund
LGTM. Awesome!
6 years, 3 months ago (2014-09-12 15:52:25 UTC) #3
danrubel
PTAL. Revised after more trials on Windows.
6 years, 3 months ago (2014-09-22 13:26:44 UTC) #5
scheglov
LGTM
6 years, 3 months ago (2014-09-22 13:44:28 UTC) #6
danrubel
6 years, 3 months ago (2014-09-22 17:30:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698