Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: chrome/browser/ui/views/toolbar/browser_action_view.h

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_action_view.h
diff --git a/chrome/browser/ui/views/toolbar/browser_action_view.h b/chrome/browser/ui/views/toolbar/browser_action_view.h
index a52bc6d67869069a5a3bd87cd51516c240b81206..16a70149e2229a78bc33011b663b7aff0c84ca67 100644
--- a/chrome/browser/ui/views/toolbar/browser_action_view.h
+++ b/chrome/browser/ui/views/toolbar/browser_action_view.h
@@ -64,6 +64,11 @@ class BrowserActionView : public views::MenuButton,
// Hides the active popup of the delegate, if one exists.
virtual void HideActivePopup() = 0;
+ // Returns the primary BrowserActionView associated with the given
+ // |extension|.
+ virtual BrowserActionView* GetMainViewForExtension(
+ const extensions::Extension* extension) = 0;
+
protected:
virtual ~Delegate() {}
};
@@ -159,6 +164,8 @@ class BrowserActionView : public views::MenuButton,
virtual bool IsShownInMenu() OVERRIDE;
virtual views::FocusManager* GetFocusManagerForAccelerator() OVERRIDE;
virtual views::Widget* GetParentForContextMenu() OVERRIDE;
+ virtual ExtensionActionViewController* GetPreferredPopupViewController()
+ OVERRIDE;
virtual views::View* GetReferenceViewForPopup() OVERRIDE;
virtual content::WebContents* GetCurrentWebContents() OVERRIDE;
virtual void HideActivePopup() OVERRIDE;
« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_image_view.cc ('k') | chrome/browser/ui/views/toolbar/browser_action_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698