chrome/browser/ui/views/location_bar/page_action_image_view.cc - Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.cc

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master for CQ Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_image_view.h ('k') | chrome/browser/ui/views/toolbar/browser_action_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc

diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.cc b/chrome/browser/ui/views/location_bar/page_action_image_view.cc

index e690f066c594d4a33362309e8960c35abfc5b7d0..793f524a316cd04d89d2b246ea92d27c857c381d 100644

--- a/chrome/browser/ui/views/location_bar/page_action_image_view.cc

+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.cc

@@ -138,6 +138,11 @@ views::Widget* PageActionImageView::GetParentForContextMenu() {

return GetWidget();

}

+ExtensionActionViewController*

+PageActionImageView::GetPreferredPopupViewController() {

+ return view_controller_.get();

views::View* PageActionImageView::GetReferenceViewForPopup() {

return this;

}