Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_view_delegate.h

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_action_view_delegate.h
diff --git a/chrome/browser/ui/views/extensions/extension_action_view_delegate.h b/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
index 5a86e68d88c65491b649f4e3110ce493896a49ac..ca74a0621d4abe71a6a1b6038c218daca3e08b1b 100644
--- a/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
+++ b/chrome/browser/ui/views/extensions/extension_action_view_delegate.h
@@ -15,6 +15,8 @@ class View;
class Widget;
}
+class ExtensionActionViewController;
+
// The view that surrounds an ExtensionAction and owns the
// ExtensionActionViewController. Since different actions can subclass
// different views, we don't derive views::View directly here.
@@ -33,6 +35,11 @@ class ExtensionActionViewDelegate {
// Returns the parent for the associated context menu.
virtual views::Widget* GetParentForContextMenu() = 0;
+ // In some cases (such as when an action is shown in a menu), a substitute
+ // ExtensionActionViewController should be used for showing popups. This
+ // returns the preferred control.
+ virtual ExtensionActionViewController* GetPreferredPopupViewController() = 0;
+
// Returns the reference view for the extension action's popup.
virtual views::View* GetReferenceViewForPopup() = 0;

Powered by Google App Engine
This is Rietveld 408576698