Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5733)

Unified Diff: chrome/browser/ui/views/extensions/extension_action_view_controller.cc

Issue 561023002: Use the wrench menu as a reference view for overflowed extension actions' popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_action_view_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_action_view_controller.cc
diff --git a/chrome/browser/ui/views/extensions/extension_action_view_controller.cc b/chrome/browser/ui/views/extensions/extension_action_view_controller.cc
index 9256bd0b36e9279b8869b19bab76eacc64f30f97..e03d2968fcd5076781be3515969879ef41814500 100644
--- a/chrome/browser/ui/views/extensions/extension_action_view_controller.cc
+++ b/chrome/browser/ui/views/extensions/extension_action_view_controller.cc
@@ -72,7 +72,8 @@ bool ExtensionActionViewController::ExecuteAction(
ExecuteExtensionAction(extension_, browser_, grant_tab_permissions) ==
ExtensionAction::ACTION_SHOW_POPUP) {
GURL popup_url = extension_action_->GetPopupUrl(GetCurrentTabId());
- if (ShowPopupWithUrl(show_action, popup_url)) {
+ if (delegate_->GetPreferredPopupViewController()->ShowPopupWithUrl(
+ show_action, popup_url)) {
delegate_->OnPopupShown(grant_tab_permissions);
return true;
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_action_view_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698