Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 560963002: [Android] Prevent IME from hiding text handles if selection not editable (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Prevent IME from hiding text handles if selection not editable Prevent hardware keyboard events from hiding text handles if the events are not dispatched to an editable region. This allows seamless arrow key navigation of the page while a (non-editable) selection is active. BUG=409778 Committed: https://crrev.com/02399778922b0791d5df14e140a2c9ca1a37847e Cr-Commit-Position: refs/heads/master@{#294251}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jdduke (slow)
aurimas@: PTAL, thanks.
6 years, 3 months ago (2014-09-10 21:01:16 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 3 months ago (2014-09-10 21:05:37 UTC) #3
aurimas (slooooooooow)
lgtm lgtm
6 years, 3 months ago (2014-09-10 21:05:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/560963002/20001
6 years, 3 months ago (2014-09-10 21:15:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4921a6dca3627a50a6b972d8425f763055c3e9c6
6 years, 3 months ago (2014-09-10 23:04:30 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:13:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02399778922b0791d5df14e140a2c9ca1a37847e
Cr-Commit-Position: refs/heads/master@{#294251}

Powered by Google App Engine
This is Rietveld 408576698