content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 560963002: [Android] Prevent IME from hiding text handles if selection not editable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 560963002: [Android] Prevent IME from hiding text handles if selection not editable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index ff04d4d22aeeeee8194217f4a35e4948afb59331..627a802d025a4209ca140768fe769f5f8b08fb02 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -537,7 +537,7 @@ public class ContentViewCore

public void onImeEvent() {

mPopupZoomer.hide(true);

getContentViewClient().onImeEvent();

- hideTextHandles();

+ if (mFocusedNodeEditable) hideTextHandles();

}

@Override

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | no next file with comments »