Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 56096: Delete downloads after updating observers.... (Closed)

Created:
11 years, 8 months ago by Paul Godavari
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Delete downloads after updating observers. The download page adds itself as an observer to in-progress and unconfirmed dangerous downloads, and removes itself when the download manager indicates its state has changed. This caused a crash when the downloads were deleted during a "clear browsing data" operation, since the delete happened before the download page was notified of a download manager state change. The download page then attempted to remove itself from a deleted item. BUG=9444 (http://crbug.com/9444) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12874

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/download/download_manager.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Paul Godavari
11 years, 8 months ago (2009-03-31 01:29:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698