Delete downloads after updating observers....

chrome/browser/download/download_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_manager.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 999 matching lines @@
   // Tell observers to refresh their views.
   FOR_EACH_OBSERVER(Observer, observers_, ModelChanged());
 
   delete download;
 }
 
 int DownloadManager::RemoveDownloadsBetween(const base::Time remove_begin,
                                             const base::Time remove_end) {
   RemoveDownloadsFromHistoryBetween(remove_begin, remove_end);
 
-  int num_deleted = 0;
   DownloadMap::iterator it = downloads_.begin();
+  std::vector<DownloadItem*> pending_deletes;
   while (it != downloads_.end()) {
     DownloadItem* download = it->second;
     DownloadItem::DownloadState state = download->state();
     if (download->start_time() >= remove_begin &&
         (remove_end.is_null() || download->start_time() < remove_end) &&
         (state == DownloadItem::COMPLETE ||
          state == DownloadItem::CANCELLED)) {
       // Remove from the map and move to the next in the list.
       downloads_.erase(it++);
 
       // Also remove it from any completed dangerous downloads.
       DownloadMap::iterator dit = dangerous_finished_.find(download->id());
       if (dit != dangerous_finished_.end())
         dangerous_finished_.erase(dit);
 
-      delete download;
+      pending_deletes.push_back(download);
 
-      ++num_deleted;
       continue;
     }
 
     ++it;
   }
 
   // Tell observers to refresh their views.
+  int num_deleted = static_cast<int>(pending_deletes.size());
   if (num_deleted > 0)
     FOR_EACH_OBSERVER(Observer, observers_, ModelChanged());
 
+  // Delete the download items after updating the observers.
+  STLDeleteContainerPointers(pending_deletes.begin(), pending_deletes.end());
+  pending_deletes.clear();
+
   return num_deleted;
 }
 
 int DownloadManager::RemoveDownloads(const base::Time remove_begin) {
   return RemoveDownloadsBetween(remove_begin, base::Time());
 }
 
 // Initiate a download of a specific URL. We send the request to the
 // ResourceDispatcherHost, and let it send us responses like a regular
 // download.
@@ skipping 386 matching lines @@
       searched_downloads.push_back(dit->second);
   }
 
   requestor->SetDownloads(searched_downloads);
 }
 
 // Clears the last download path, used to initialize "save as" dialogs.
 void DownloadManager::ClearLastDownloadPath() {
   last_download_path_ = FilePath();
 }