Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560913005: Move HTMLFormElement bool members to bit-fields (Closed)

Created:
6 years, 3 months ago by spartha
Modified:
6 years, 3 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use bit-fields for space saving in HTMLFormElement. Reduces the size by 8 bytes per instance. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182319

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/html/HTMLFormElement.h View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spartha
PTAL!
6 years, 3 months ago (2014-09-15 20:33:10 UTC) #2
keishi
https://codereview.chromium.org/560913005/diff/1/Source/core/html/HTMLFormElement.h File Source/core/html/HTMLFormElement.h (right): https://codereview.chromium.org/560913005/diff/1/Source/core/html/HTMLFormElement.h#newcode175 Source/core/html/HTMLFormElement.h:175: #endif nit: extra space. https://codereview.chromium.org/560913005/diff/1/Source/core/html/HTMLFormElement.h#newcode176 Source/core/html/HTMLFormElement.h:176: unsigned m_associatedElementsAreDirty : ...
6 years, 3 months ago (2014-09-18 04:23:19 UTC) #3
spartha
PTAL! https://codereview.chromium.org/560913005/diff/1/Source/core/html/HTMLFormElement.h File Source/core/html/HTMLFormElement.h (right): https://codereview.chromium.org/560913005/diff/1/Source/core/html/HTMLFormElement.h#newcode175 Source/core/html/HTMLFormElement.h:175: #endif On 2014/09/18 04:23:19, keishi wrote: > nit: ...
6 years, 3 months ago (2014-09-18 09:05:39 UTC) #4
keishi
lgtm
6 years, 3 months ago (2014-09-19 06:54:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560913005/20001
6 years, 3 months ago (2014-09-19 11:33:41 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 12:34:25 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182319

Powered by Google App Engine
This is Rietveld 408576698