Move HTMLFormElement bool members to bit-fields

Source/core/html/HTMLFormElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 154 matching lines @@
     OwnPtrWillBeMember<PastNamesMap> m_pastNamesMap;
 
     RadioButtonGroupScope m_radioButtonGroupScope;
 
     // Do not access m_associatedElements directly. Use associatedElements() instead.
     FormAssociatedElement::List m_associatedElements;
     // Do not access m_imageElements directly. Use imageElements() instead.
     WillBeHeapVector<RawPtrWillBeMember<HTMLImageElement> > m_imageElements;
 #if !ENABLE(OILPAN)
     WeakPtrFactory<HTMLFormElement> m_weakPtrFactory;
-#endif
-    bool m_associatedElementsAreDirty;
-    bool m_imageElementsAreDirty;
-    bool m_hasElementsAssociatedByParser;
-    bool m_didFinishParsingChildren;
+#endif 

[keishi, 2014/09/18 04:23:19]

nit: extra space.

[spartha, 2014/09/18 09:05:39]

Done.

+    unsigned m_associatedElementsAreDirty : 1;

[keishi, 2014/09/18 04:23:19]

Do we need to change the type to unsigned?

[spartha, 2014/09/18 09:05:39]

Done.

+    unsigned m_imageElementsAreDirty : 1;
+    unsigned m_hasElementsAssociatedByParser : 1;
+    unsigned m_didFinishParsingChildren : 1;
 
-    bool m_wasUserSubmitted;
-    bool m_isSubmittingOrInUserJSSubmitEvent;
-    bool m_shouldSubmit;
+    unsigned m_wasUserSubmitted : 1;
+    unsigned m_isSubmittingOrInUserJSSubmitEvent : 1;
+    unsigned m_shouldSubmit : 1;
 
-    bool m_isInResetFunction;
+    unsigned m_isInResetFunction : 1;
 
-    bool m_wasDemoted;
+    unsigned m_wasDemoted : 1;
 
     OwnPtrWillBeMember<GenericEventQueue> m_pendingAutocompleteEventsQueue;
 };
 
 } // namespace blink
 
 #endif // HTMLFormElement_h