Interface for requestSources through UserMediaController/Client.

Interface for requestSources through UserMediaController/Client.

This allows MediaStreamTrack::getSources to go through UserMediaClient.

To land after this:
Chrome CL part 1: https://codereview.chromium.org/562643003/
Blink CL part 2: https://codereview.chromium.org/559423002
Chrome CL part 2 (TBD)

BUG=406094
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181822

[Henrik Grunell, 2014-09-10 13:01:28]

grunell@chromium.org changed reviewers:
+ jochen@chromium.org

[Henrik Grunell, 2014-09-10 13:01:47]

Please review.

[jochen (gone - plz use gerrit), 2014-09-11 11:35:44]

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStreamTrack.cpp (right):

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStreamTrack.cpp:135:
exceptionState.throwDOMException(NotSupportedError, "No sources controller
available; is this a detached window?");
That's an odd exception. What would a developer do with this? Maybe we should
just return an empty sources list?

[Henrik Grunell, 2014-09-11 11:43:23]

One thing I wonder is if MediaStreamTrackSourcesRequest should be an
ActiveDOMObject?

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStreamTrack.cpp (right):

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStreamTrack.cpp:135:
exceptionState.throwDOMException(NotSupportedError, "No sources controller
available; is this a detached window?");
On 2014/09/11 11:35:44, jochen wrote:
> That's an odd exception. What would a developer do with this? Maybe we should
> just return an empty sources list?

Hmm, I borrowed this from NavigatorMediaStream::webkitGetUserMedia and
NavigatorMediaStream::getMediaDevices. I suppose (hope) it makes sense. :) I
think we should really have a controller. Wdyt?

[jochen (gone - plz use gerrit), 2014-09-11 11:48:51]

On 2014/09/11 at 11:43:23, grunell wrote:
> One thing I wonder is if MediaStreamTrackSourcesRequest should be an
ActiveDOMObject?
>

why? It's not exposed to javascript, is it? I couldn't find an IDL for it

[jochen (gone - plz use gerrit), 2014-09-11 11:49:21]

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStreamTrack.cpp (right):

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStreamTrack.cpp:135:
exceptionState.throwDOMException(NotSupportedError, "No sources controller
available; is this a detached window?");
On 2014/09/11 at 11:43:22, Henrik Grunell wrote:
> On 2014/09/11 11:35:44, jochen wrote:
> > That's an odd exception. What would a developer do with this? Maybe we
should
> > just return an empty sources list?
> 
> Hmm, I borrowed this from NavigatorMediaStream::webkitGetUserMedia and
NavigatorMediaStream::getMediaDevices. I suppose (hope) it makes sense. :) I
think we should really have a controller. Wdyt?

ok I guess

[Henrik Grunell, 2014-09-11 11:55:35]

On 2014/09/11 11:48:51, jochen wrote:
> On 2014/09/11 at 11:43:23, grunell wrote:
> > One thing I wonder is if MediaStreamTrackSourcesRequest should be an
> ActiveDOMObject?
> >
> 
> why? It's not exposed to javascript, is it? I couldn't find an IDL for it

Right. Because I saw that MediaDevicesRequest is, and it's not exposed either.
That one is probably not correct then.

[Henrik Grunell, 2014-09-11 11:58:51]

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
File Source/modules/mediastream/MediaStreamTrack.cpp (right):

https://codereview.chromium.org/560843002/diff/20001/Source/modules/mediastre...
Source/modules/mediastream/MediaStreamTrack.cpp:135:
exceptionState.throwDOMException(NotSupportedError, "No sources controller
available; is this a detached window?");
On 2014/09/11 11:49:21, jochen wrote:
> On 2014/09/11 at 11:43:22, Henrik Grunell wrote:
> > On 2014/09/11 11:35:44, jochen wrote:
> > > That's an odd exception. What would a developer do with this? Maybe we
> should
> > > just return an empty sources list?
> > 
> > Hmm, I borrowed this from NavigatorMediaStream::webkitGetUserMedia and
> NavigatorMediaStream::getMediaDevices. I suppose (hope) it makes sense. :) I
> think we should really have a controller. Wdyt?
> 
> ok I guess

OK. Can you please continue review the CL?

[jochen (gone - plz use gerrit), 2014-09-11 12:03:15]

lgtm

[Henrik Grunell, 2014-09-11 13:02:15]

I removed the change in MediaStreamTrack, will put it in a separate CL, and land
that after landing the Chromium implementation.

Also, added empty default implementation of requestSources, will be removed
after landing the Chromium implementation.

[Henrik Grunell, 2014-09-11 13:10:49]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2014-09-11 13:11:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/560843002/40001

[commit-bot: I haz the power, 2014-09-11 15:30:38]

Committed patchset #3 (id:40001) as 181822