Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 559423002: Change MediaStreamTrack::getSources to go through UserMediaClient. (Closed)

Created:
6 years, 3 months ago by Henrik Grunell
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, philipj_slow, tommyw+watchlist_chromium.org
Project:
blink
Visibility:
Public.

Description

Change MediaStreamTrack::getSources to go through UserMediaClient. This makes MediaStreamTrack::getSources go through UserMediaClient instead, needed to know which frame the call came from. Depending on: Blink CL part 1: https://codereview.chromium.org/560843002 Chrome CL part 1: https://codereview.chromium.org/562643003/ Chrome CL part 2: https://codereview.chromium.org/564423002/ BUG=406094 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182141

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M public/web/WebUserMediaClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Henrik Grunell
This is just a break-out of https://codereview.chromium.org/560843002/ which you already reviewed and lgtm'd.
6 years, 3 months ago (2014-09-11 13:09:51 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-11 13:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423002/20001
6 years, 3 months ago (2014-09-15 08:45:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55890)
6 years, 3 months ago (2014-09-15 08:56:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423002/40001
6 years, 3 months ago (2014-09-16 17:16:58 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-16 19:17:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423002/40001
6 years, 3 months ago (2014-09-17 08:35:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559423002/60001
6 years, 3 months ago (2014-09-17 08:35:37 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 08:36:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 182141

Powered by Google App Engine
This is Rietveld 408576698