Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 56083005: Docserver: Cleanup to remove the APIListDataSource dependency from (Closed)

Created:
7 years, 1 month ago by not at google - send to devlin
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Cleanup to remove the APIListDataSource dependency from ReferenceResolver, allowing for deleting APIListDataSource.GetAllNames. R=yoz@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232808

Patch Set 1 #

Patch Set 2 : yaml #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source_test.py View 8 chunks +29 lines, -29 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/reference_resolver.py View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/reference_resolver_test.py View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
This is to reduce the amount of work needed in https://codereview.chromium.org/48263002. Those tests which I've ...
7 years, 1 month ago (2013-11-02 00:12:36 UTC) #1
Yoyo Zhou
LGTM, nice cleanup
7 years, 1 month ago (2013-11-04 20:39:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/56083005/80001
7 years, 1 month ago (2013-11-04 21:19:15 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-04 21:34:01 UTC) #4
Message was sent while issue was closed.
Change committed as 232808

Powered by Google App Engine
This is Rietveld 408576698