Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: chrome/common/extensions/docs/server2/reference_resolver_test.py

Issue 56083005: Docserver: Cleanup to remove the APIListDataSource dependency from (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/reference_resolver_test.py
diff --git a/chrome/common/extensions/docs/server2/reference_resolver_test.py b/chrome/common/extensions/docs/server2/reference_resolver_test.py
index 8a478577a6ced0b09a47678d83c0ec9666c48a08..3cbcea32f06bf71ea988c9c7c6e648b3e4340aa0 100755
--- a/chrome/common/extensions/docs/server2/reference_resolver_test.py
+++ b/chrome/common/extensions/docs/server2/reference_resolver_test.py
@@ -12,6 +12,7 @@ from file_system import FileNotFoundError
from reference_resolver import ReferenceResolver
from test_object_store import TestObjectStore
+
class FakeAPIDataSource(object):
def __init__(self, json_data):
self._json = json_data
@@ -22,8 +23,14 @@ class FakeAPIDataSource(object):
raise FileNotFoundError(key)
return self._json[key]
- def GetAllNames(self):
- return self._json.keys()
+
+class FakeAPIModels(object):
+ def __init__(self, names):
+ self._names = names
+
+ def GetNames(self):
+ return self._names
+
class APIDataSourceTest(unittest.TestCase):
def setUp(self):
@@ -34,10 +41,9 @@ class APIDataSourceTest(unittest.TestCase):
return f.read()
def testGetLink(self):
- data_source = FakeAPIDataSource(
- json.loads(self._ReadLocalFile('fake_data_source.json')))
- resolver = ReferenceResolver(data_source,
- data_source,
+ test_data = json.loads(self._ReadLocalFile('fake_data_source.json'))
+ resolver = ReferenceResolver(FakeAPIDataSource(test_data),
+ FakeAPIModels(test_data.keys()),
TestObjectStore('test'))
self.assertEqual({
'href': 'foo.html',
« no previous file with comments | « chrome/common/extensions/docs/server2/reference_resolver.py ('k') | chrome/common/extensions/docs/server2/server_instance.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698