Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560653004: SkData can allocate room for its contents in the same block (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkData can allocate room for its contents in the same block BUG=skia: Committed: https://skia.googlesource.com/skia/+/33a30503d76fdd989358cedd78445ba96bb809dd

Patch Set 1 #

Patch Set 2 : use real proc address, call destructor when inplace #

Total comments: 4

Patch Set 3 : update dox, change fPtr to non const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -79 lines) Patch
M include/core/SkData.h View 1 2 6 chunks +35 lines, -6 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkData.cpp View 1 2 3 chunks +50 lines, -8 lines 0 comments Download
M src/core/SkFlattenableSerialization.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkStream.cpp View 6 chunks +17 lines, -18 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +13 lines, -15 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFShader.cpp View 2 chunks +7 lines, -11 lines 0 comments Download
M src/sfnt/SkOTUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
reed1
6 years, 3 months ago (2014-09-11 14:42:56 UTC) #2
reed1
ptal
6 years, 3 months ago (2014-09-11 14:52:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560653004/20001
6 years, 3 months ago (2014-09-11 14:53:00 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-11 14:53:01 UTC) #6
bungeman-skia
lgtm with one nit https://codereview.chromium.org/560653004/diff/20001/src/core/SkData.cpp File src/core/SkData.cpp (right): https://codereview.chromium.org/560653004/diff/20001/src/core/SkData.cpp#newcode28 src/core/SkData.cpp:28: // to point right after ...
6 years, 3 months ago (2014-09-11 15:17:16 UTC) #8
mtklein
https://codereview.chromium.org/560653004/diff/20001/include/core/SkData.h File include/core/SkData.h (right): https://codereview.chromium.org/560653004/diff/20001/include/core/SkData.h#newcode54 include/core/SkData.h:54: return const_cast<void*>(fPtr); Let's make fPtr just void*? It'll still ...
6 years, 3 months ago (2014-09-11 15:17:55 UTC) #9
reed1
https://codereview.chromium.org/560653004/diff/20001/include/core/SkData.h File include/core/SkData.h (right): https://codereview.chromium.org/560653004/diff/20001/include/core/SkData.h#newcode54 include/core/SkData.h:54: return const_cast<void*>(fPtr); On 2014/09/11 15:17:55, mtklein wrote: > Let's ...
6 years, 3 months ago (2014-09-11 15:28:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560653004/40001
6 years, 3 months ago (2014-09-11 15:34:03 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 15:42:40 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 33a30503d76fdd989358cedd78445ba96bb809dd

Powered by Google App Engine
This is Rietveld 408576698