src/pdf/SkPDFGraphicState.cpp - Issue 560653004: SkData can allocate room for its contents in the same block

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFGraphicState.cpp

Issue 560653004: SkData can allocate room for its contents in the same block (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update dox, change fPtr to non const Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFGraphicState.cpp

diff --git a/src/pdf/SkPDFGraphicState.cpp b/src/pdf/SkPDFGraphicState.cpp

index bd8afe0684365fe64059df1f69cb530cd96254c5..7664ed699b24f89a2385f3438610e9d9d6f1599a 100644

--- a/src/pdf/SkPDFGraphicState.cpp

+++ b/src/pdf/SkPDFGraphicState.cpp

@@ -123,7 +123,7 @@ SkPDFObject* SkPDFGraphicState::GetInvertFunction() {

static const char psInvert[] = "{1 exch sub}";

// Do not copy the trailing '\0' into the SkData.

SkAutoTUnref<SkData> psInvertStream(

- SkData::NewWithCopy(psInvert, strlen(psInvert)));

+ SkData::NewWithoutCopy(psInvert, strlen(psInvert)));

invertFunction = new SkPDFStream(psInvertStream.get());

invertFunction->insertInt("FunctionType", 4);

« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | src/pdf/SkPDFShader.cpp » ('j') | no next file with comments »